DEVPROD-16438 - migrate perf.send to cedar_report endpoint #1679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbabanin
reviewed
Apr 24, 2025
Comment on lines
+782
to
+789
| script: | | ||
| if [ "${requester}" == "commit" ]; then | ||
| echo "is_mainline: true" >> expansion.yml | ||
| else | ||
| echo "is_mainline: false" >> expansion.yml | ||
| fi | ||
|
|
||
| echo "parsed_order_id: $(echo "${revision_order_id}" | awk -F'_' '{print $NF}')" >> expansion.yml |
There was a problem hiding this comment.
Could we move this script into a single shell.exec command at line 793? It looks like we might be able to skip expansions.update, which could help keep the CI file a bit more concise.
There was a problem hiding this comment.
I did try this originally, but evergreen was not handling the variable assignment without them being written to the expansions unfortunately, the variables were not being retained after assignment (showing up as null when I recalled them).
|
@vbabanin I've made updates with regards to your feedback, here is a new patch: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The perf.send functionality in evergreen is no longer maintained and is not the preferred method of sending performance data to the signal processing service. This PR updates the evergreen yaml file to instead send the data down stream using the preferred
performance-monitoring-api.corp.mongodb.com/raw_perf_results/cedar_reportend point.Changes were tested in this patch and data was confirmed to be sending correctly.